-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate debug flag handling #5390
base: main
Are you sure you want to change the base?
Conversation
This pull request has merge conflicts that need to be resolved. |
e90aef1
to
f7d165f
Compare
f7d165f
to
e51ffd1
Compare
This pull request has merge conflicts that need to be resolved. |
e51ffd1
to
b5c9e56
Compare
b5c9e56
to
f5c848e
Compare
This pull request has merge conflicts that need to be resolved. |
f5c848e
to
aeefa47
Compare
This pull request has merge conflicts that need to be resolved. |
aeefa47
to
104340e
Compare
This pull request has merge conflicts that need to be resolved. |
104340e
to
c60e362
Compare
c60e362
to
da618f5
Compare
This pull request has merge conflicts that need to be resolved. |
da618f5
to
b232012
Compare
This pull request has merge conflicts that need to be resolved. |
Introduce internal.DebugFlags to replace debug and verbose logging flag handling. Move the flag definitions from the "PersistentFlagSet" to a struct method. Remove the debug flag handling from the root command and move it to the subcommands. This allows for the removal of CallPersistentPreRun, since the commands no longer rely on proper chaining of the PersistentPreRun hooks. Signed-off-by: Tom Wieczorek <[email protected]>
b232012
to
cbabdbb
Compare
Description
Introduce
internal.DebugFlags
to replace debug and verbose logging flag handling. Move the flag definitions from the "PersistentFlagSet" to a struct method. Remove the debug flag handling from the root command and move it to the sub-commands. This allows for the removal ofCallPersistentPreRun
, since the commands no longer rely on proper chaining of the PersistentPreRun hooks. Remove some redundant calls to the "PersistentFlagSet" in some sub-commands.Type of change
How Has This Been Tested?
Checklist: