Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.31] Use localhost in admin kubeconfig again, if possible #5434

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[Backport release-1.31] Use localhost in admin kubeconfig again, if possible #5434

merged 1 commit into from
Jan 14, 2025

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 14, 2025 •
edited
Loading

@twz123
Use localhost in admin kubeconfig again, if possible
eff3020 
If the API server is binding to all addresses, it's better to use the
loopback interface to communicate with the API server locally. This
avoids e.g. weird HTTP proxy problems.

See: a759281 ("replace BindAddress by Address and OnlyBindToAddress")
See: 548dc41 ("Add spec.api.bindAddress configuration")
Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 93b9f4c)
@twz123 twz123 added bug Something isn't working area/controlplane labels Jan 14, 2025
@twz123 twz123 marked this pull request as ready for review January 14, 2025 13:56
@twz123 twz123 requested a review from a team as a code owner January 14, 2025 13:56
@twz123 twz123 requested review from makhov and jnummelin January 14, 2025 13:56
@twz123 twz123 merged commit 977919d into k0sproject:release-1.31 Jan 14, 2025
91 checks passed
@twz123 twz123 deleted the backport-5426-to-release-1.31 branch January 14, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa ncopa approved these changes

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @ncopa