Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syncMetadata now takes into account that matched files can have a bucketPrefix #94

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

JoaquinFernandez
Copy link

@JoaquinFernandez JoaquinFernandez commented Oct 26, 2021

What has been implemented?

When bucketPrefix is specified in options, the files are correctly copied with the prefix in the s3 bucket. If you also specify metadata in params, then syncMetadata copies objects with the REPLACE directive with them, however, it does not take into account the bucketPrefix specified.

In order to overcome that I've added the bucketPrefix to the Key without a leading / and with an ending /

Closes #86 #57

Steps to verify

  • Run serverless deploy command with bucketPrefix and without params

    • It should sync the files to the s3 bucket with the prefix and without tags
  • Run serverless deploy command with bucketPrefix and with params

@JoaquinFernandez JoaquinFernandez changed the title fiix: syncMetadata now takes into account that matched files can have a bucketPrefix fix: syncMetadata now takes into account that matched files can have a bucketPrefix Oct 26, 2021
@k1LoW k1LoW assigned k1LoW and unassigned k1LoW Oct 26, 2021
@k1LoW
Copy link
Owner

k1LoW commented Oct 26, 2021

@JoaquinFernandez Thank you !!

@k1LoW k1LoW merged commit d891017 into k1LoW:master Oct 26, 2021
@majindageta majindageta mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bucketPrefix uploads one file too much (not in localDir)
2 participants