fix: syncMetadata now takes into account that matched files can have a bucketPrefix #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been implemented?
When bucketPrefix is specified in options, the files are correctly copied with the prefix in the s3 bucket. If you also specify metadata in params, then syncMetadata copies objects with the REPLACE directive with them, however, it does not take into account the bucketPrefix specified.
In order to overcome that I've added the bucketPrefix to the Key without a leading / and with an ending /
Closes #86 #57
Steps to verify
Run serverless deploy command with bucketPrefix and without params
Run serverless deploy command with bucketPrefix and with params