Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor go generate logic #155

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Refactor go generate logic #155

merged 2 commits into from
Sep 7, 2022

Conversation

aiyengar2
Copy link
Contributor

Part 3 of #141

@aiyengar2 aiyengar2 force-pushed the modify_generate_logic branch from 2fa6821 to 17de525 Compare September 7, 2022 22:25
@aiyengar2
Copy link
Contributor Author

go generate does not produce any changes

brandond
brandond approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, we can use the CRDs from this instead of just embedding the GVK strings in K3s: https://github.com/k3s-io/k3s/blob/v1.24.4+k3s1/pkg/server/context.go#L85-L88

@brandond brandond merged commit e64bc27 into k3s-io:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiyengar2 @brandond