fix updatecli values filename, move repo info to configs

[matttrach]

Updatecli is failing because the values.yaml is named 'values.yml', this corrects that and moves the repo data from the values file to the updatecli config.
This addresses k3s-io/k3s#7363

I tested this locally by changing the owner and branch in the updatecli config to mine, adding the github env variables, and running the updatecli diff tool:

Diff Output

updatecli diff -v updatecli/values.yaml -c updatecli/updatecli.d/updatecli.yml; git reset --hard; cd ..


+++++++++++
+ PREPARE +
+++++++++++

Loading Pipeline "updatecli/updatecli.d/updatecli.yml"

SCM repository retrieved: 2


++++++++++++++++++
+ AUTO DISCOVERY +
++++++++++++++++++



++++++++++++
+ PIPELINE +
++++++++++++



################################################################
# INTRODUCE UPDATECLI TO REPO AND VALIDATE BASIC FUNCTIONALITY #
################################################################


SOURCES
=======

goTag
-----
Searching for version matching pattern "^go1\\.20\\.2$"
✔ Git tag "go1.20.2" found matching pattern "^go1\\.20\\.2$"


CONDITIONS:
===========

testVersionShouldMatchGoTag
---------------------------
✗ Key "version", in YAML file "updatecli/validate.yml", is incorrectly set to go1.20.1 and should be "go1.20.2"


TARGETS
========

updateValidateFile
------------------

**Dry Run enabled**

⚠ Key 'version', from file '/tmp/nix-shell.Loa5SD/updatecli/github/matttrach/helm-controller/updatecli/validate.yml', was updated from 'go1.20.1' to 'go1.20.2'


ACTIONS
========

[Dry Run] An action of kind "github/pullrequest" is expected.

=============================

REPORTS:


⚠ Introduce updatecli to repo and validate basic functionality:
        Source:
                ✔ [goTag] Get Go 1.20.2 tag (kind: gittag)
        Condition:
                ✔ [testVersionShouldMatchGoTag] test version should match go tag (kind: yaml)
        Target:
                ⚠ [updateValidateFile] Update the version in the validate file (kind: yaml)


Run Summary
===========
Pipeline(s) run:
  * Changed:    1
  * Failed:     0
  * Skipped:    0
  * Succeeded:  0
  * Total:      1

[macedogm]

Approved.

Just a comment, isn't better to actually keep updatecli/values.yml with the .yml extension and change it only in the workflow file?

helm-controller/.github/workflows/updatecli.yml

Line 52 in a14e7f4

run: "updatecli apply --clean --config ./updatecli/updatecli.d/ --values ./updatecli/values.yaml"

From: --values ./updatecli/values.yaml"
To: --values ./updatecli/values.yml"

This way all Updatecli files will have the same consistent extension of .yml.

[matttrach]

I wanna say that was my first thought as well, but it kinda seems like the common choice for most k3s repos is to use the full extension name, with the exception of workflows and updatecli configs. Overall I decided that this way seemed more natural, but honestly it could go either way. I just want to be consistent (across repos) with whatever choice we make, and right now that is 'values.yaml' (there are now about 30 repos set up this way). This seems like a good topic for an ADR.

[macedogm]

Thanks for the explanation, Matt. Your rationale makes sense.

This seems like a good topic for an ADR.

Agree.