When resetting/restoring etcd, only listen on loopback #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
commented
May 5, 2022
| @@ -796,6 +818,7 @@ func (e *ETCD) cluster(ctx context.Context, forceNew bool, options executor.Init | |||
| ClientCertAuth: true, | |||
| TrustedCAFile: e.config.Runtime.ETCDPeerCA, | |||
| }, | |||
| SnapshotCount: 10000, | |||
There was a problem hiding this comment.
This is for consistency with kubeadm et al: etcd-io/etcd#13889
Note that this is the number of transactions before etcd takes an internal WAL snapshot; it does not have anything to do with scheduled or on-demand snapshots.
manuelbuil
approved these changes
May 6, 2022
brandond
force-pushed
the
cluster_reset_isolation
branch
from
fe59130 to
b213011
Compare
Signed-off-by: Brad Davidson <[email protected]>
dereknola
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
bugfix
Verification
Check etcd logs during reset/restore, confirm that it is only listening for peer/client connections on loopback IP.
Linked Issues
User-Facing Change
Further Comments