Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom config to root zone #7636

Closed
wants to merge 1 commit into from

Conversation

jobcespedes
Copy link

@jobcespedes jobcespedes commented May 30, 2023

Proposed Changes

Add custom config to root zone through an import at the end of the root block.

Currently, adding custom config to root zoom requires some workarounds. Instead, an import would allow creating a key in the current custom configmap for that purpose.

Types of Changes

New Feature

Verification

Create a key in configmap with prefix .root. Ex: myhosts.root

Testing

N/A

Linked Issues

N/A

User-Facing Change

NONE

Further Comments

N/A

Add custom config to root zone through an import at the end of the root block.

Adding custom config to root zoom requires some workarounds. Instead an import, would allow creating a key in the current custom configmap for that purpose.
@jobcespedes jobcespedes requested a review from a team as a code owner May 30, 2023 23:14
@brandond
Copy link
Member

brandond commented May 30, 2023

@jobcespedes
Copy link
Author

Yep. It is. I did not know. Sorry.

@brandond
Copy link
Member

thanks anyway! This should make it into next month's releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants