Consume coredns crd plugin with WRR functionality #1141
Conversation
Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
jkremser
as code owners
|
@kuritka can be related to WRR in action https://github.com/k8gb-io/k8gb/blob/master/terratest/examples/roundrobin_weight1.yaml#L39-L44 ? I assume that before this example was never properly evaluated by terratest with older k8s_crd plugin |
|
@ytsarev , hi, probably. need to check terratests locally. |
| @@ -18,6 +18,7 @@ data: | |||
| resources DNSEndpoint | |||
| filter k8gb.absa.oss/dnstype=local | |||
| negttl {{ .Values.k8gb.dnsZoneNegTTL }} | |||
| loadbalance weight | |||
There was a problem hiding this comment.
isn't it hardcoding particular method?
There was a problem hiding this comment.
Would be great to get confirmation from @kuritka , but if I understand correctly it does standard round-robin if no WRR in Gslb spec, see k8gb-io/coredns-crd-plugin#45
There was a problem hiding this comment.
Hi @ytsarev, RR is only a subset of WRR. If weights are not defined , the RR is automatically applied. If weights are defined in CR, the WRR is used. If an error occurs for any reason, then the RR is used automatically. tahts what loadbalance weight does.
The reason why I defines this field is for extendability. I was planning that in the future there will be a loadbalance consistent for consistent hashing etc.
Signed-off-by: Yury Tsarev <[email protected]>
| prometheus 0.0.0.0:9153 | ||
| forward . /etc/resolv.conf | ||
| k8s_crd { | ||
| resources DNSEndpoint |
There was a problem hiding this comment.
@kuritka it's not immediately clear from k8gb-io/coredns-crd-plugin#45 - why do we need to remove this config line?
There was a problem hiding this comment.
resources DNSEndpoint field was meaningless, we didn't work with it in any way.
There was a problem hiding this comment.
@kuritka cool, I was mostly wondering why it actually breaking the terratest, but cool to get rid of it any case, thanks!
No description provided.