New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax requirement on k8gb namespace name #215

Merged

ytsarev merged 1 commit into master from namespace-relax

Dec 11, 2020

Member

ytsarev commented Dec 11, 2020

Do not rely on hardcoded k8gb namespace anymore
Helm chart template fix
Dynamically get current k8gb controller namespace
with the help of Downward API
https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-pod-fields-as-values-for-environment-variables
Resolves Relax dependency on specific 'k8gb' namespace name #129


          Relax requirement on k8gb namespace name

0a142d3

* Do not rely on hardcoded `k8gb` namespace anymore
* Helm chart template fix
* Dynamically get current k8gb controller namespace
  with the help of Downward API
  https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-pod-fields-as-values-for-environment-variables
* Resolves #129

ytsarev requested review from donovanmuller, k0da, kuritka and somaritane as code owners

December 11, 2020 12:32

k0da approved these changes

View reviewed changes

Collaborator

k0da left a comment

LGTM

ytsarev merged commit bd20dc7 into master

ytsarev deleted the namespace-relax branch

December 11, 2020 14:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

k0da k0da approved these changes

donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

kuritka Awaiting requested review from kuritka kuritka is a code owner

somaritane Awaiting requested review from somaritane

Labels

None yet