Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor prettyPrint #258

Merged
merged 1 commit into from
Jan 18, 2021
Merged

refactor prettyPrint #258

merged 1 commit into from
Jan 18, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Jan 18, 2021 •
edited
Loading

  • move prettyPrint to utility package, rename to ToString()
  • test coverage
  • Function returns string only. Possible errors covered, see: TestUnsupportedValueError,TestUnsupportedTypeError

@kuritka
refactor prettyPrint
d264831 
 - clarify prossible errors. Function returns string only. Possible errors covered by tests  `TestUnsupportedValueError`,`TestUnsupportedTypeError`
 - test implementation
 - replace prettyPrint by utility function ToString()
somaritane
somaritane approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kuritka kuritka merged commit f5d5533 into master Jan 18, 2021
@kuritka kuritka deleted the refactor-prettyPrint branch January 20, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somaritane somaritane somaritane approved these changes

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuritka @somaritane @ytsarev