Validate spec.ingress.http.path #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
|
@ytsarev @somaritane - as we discussed. @kuritka It is cheap to cut off broken boject by api validation and not coplicate depresolver with essential data requirement. As for Ingress: we'll catch errors by same api validator, and throw an error, so broken object won't be created and controller won't observe it. |
|
If app doesn't start because |
kuritka
previously approved these changes
Feb 22, 2021
somaritane
suggested changes
Feb 22, 2021
Require .spec.ingress.http.path as it is required for gslb to function. If broken Gslb submitted, it will be rejected by openapi v3 validation. Same will happen when using Ingress annotations, we won't create broken Gslb object but log an error message instead. Signed-off-by: Dinar Valeev <[email protected]>
ytsarev
reviewed
Feb 22, 2021
| spec: | ||
| rules: | ||
| - host: notfound.cloud.example.com | ||
| #http: |
There was a problem hiding this comment.
Just a quick way to make it invalid for gslb controller, but keeping it visible.
ytsarev
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require .spec.ingress.http.path as it is required for gslb to function.
If broken Gslb submitted, it will be rejected by openapi v3 validation.
Same will happen when using Ingress annotations, we won't create broken
Gslb object but log an error message instead.
Signed-off-by: Dinar Valeev [email protected]