Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317, depresolver load new values when GSLB recreated #322

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Feb 26, 2021

closes #317

depresolver updates itself when gslb changed

  • verified by terratest
  • because functionality changed, I had to fix unit-tests
  • goimports -w ./ pushed me to minor changes over terratests

k0da
k0da previously approved these changes Feb 26, 2021
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

closes #317

depresolver updates itself when gslb changed
  - verified by terratest
  - because functionality chenged, I had to fix unit-tests
  - `goimports -w ./` pushed me to minor changes over terratests
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kuritka kuritka merged commit f7113d8 into master Feb 26, 2021
@kuritka kuritka deleted the annotations-init-fix branch February 26, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Split brain TXT record expired the time threshold: (0s)" when gslb CR gets recreated
4 participants