Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache 2 license header to every Go file #343

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Mar 3, 2021

  • Add Apache 2 headers
  • Add incredible piece of automation for header injection

@kuritka
Copy link
Collaborator

kuritka commented Mar 3, 2021

I dind't study deepply, but there are tools doing that: https://github.com/cloudposse/copyright-header. Maybe we can manipulate with headers before GOLINT

@ytsarev
Copy link
Member Author

ytsarev commented Mar 4, 2021

@kuritka I definitely don't want to employ super sophisticated machinery with lots of rubygem dependencies here.

Also tried https://github.com/google/addlicense . It does pretty much the same stuff as the tiny shell script provided.

So I suggest we stick with the simplest version of it which does not bring in any new dependencies

@ytsarev ytsarev requested a review from k0da March 4, 2021 08:16
kuritka
kuritka previously approved these changes Mar 4, 2021
@ytsarev ytsarev requested a review from kuritka March 4, 2021 08:24
@ytsarev ytsarev merged commit 05595a8 into master Mar 4, 2021
@ytsarev ytsarev deleted the bloody_headers branch March 4, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants