Logger factory #356
Merged
Logger factory #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
k0da
previously approved these changes
Mar 10, 2021
somaritane
suggested changes
Mar 10, 2021
- logger factory implementation - Move client attribute from depresolver NewDependencyResolver() to ResolveSpec(clien.Client). Thanks to that we can resolve configuration when main function starts instead of after manager is is instantiated. Now, immediately after obtaining the configuration, we can create a logger instance. Just on the beginning of the program. Together with moving attribute I had to fix tetsts - move resolving configuration on the top of main and initialize logger just after that - remove setupLog from main. new logger takes it's his role. the new logger will be used across whole app. - Change resolving `LOG_FORMAT`, in case is not given, default value is json instead of simple. Related to #331
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.Clientargument from depresolver NewDependencyResolver() to ResolveSpec(client.Client).Thanks to that we can resolve configuration when main function starts instead of
after manager is is instantiated. Now, immediately after obtaining the configuration,
we can create a logger instance. Just at the beginning of the program.
Together with moving
clientargument, I had to fix tests.LOG_FORMATresolving, in case variable is not provided, default value isjsoninstead ofsimple.Related to #331
Logger is configured, third line is from the second logger which is still present in reconciliation
Config.Log was incorrectly configured, fail fast and print messages with default logger
Config.Log was not resolved so default logger was returned [json, info]