Licenses to be compatible with vscode editor #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vs code or maybe some plugins automatically removed space behing comment "# \n" -> "#\n". Such behavior leads to inject new license after `make license` is called. I patched golic, and released `v0.3.1` and fixed licenses in k8gb
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
changed the title
ytsarev
approved these changes
Mar 16, 2021
somaritane
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vs code editor or maybe some plugins automatically removed space behind empty-line comment
# \n->#\n. Such behavior leads to injecting new license aftermake licenseis called.I patched golic, and released
v0.3.1and fixed licenses in k8gbin GO <1.16, GOLIC will be upgraded automatically if you remove old one.
please run :
rm -f $(which golic)