Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kustomize and associated make targets #393

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

somaritane
Copy link
Contributor

Remove kustomize and associated OperatorSDK boilerplate targets

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to clean up the generated files under config/ as well

find . -iname '*kustom*'
./config/webhook/kustomizeconfig.yaml
./config/webhook/kustomization.yaml
./config/rbac/kustomization.yaml
./config/default/kustomization.yaml
./config/samples/kustomization.yaml
./config/manager/kustomization.yaml
./config/certmanager/kustomizeconfig.yaml
./config/certmanager/kustomization.yaml
./config/prometheus/kustomization.yaml
./config/scorecard/kustomization.yaml

@somaritane
Copy link
Contributor Author

We probably want to clean up the generated files under config/ as well

find . -iname '*kustom*'
./config/webhook/kustomizeconfig.yaml
./config/webhook/kustomization.yaml
./config/rbac/kustomization.yaml
./config/default/kustomization.yaml
./config/samples/kustomization.yaml
./config/manager/kustomization.yaml
./config/certmanager/kustomizeconfig.yaml
./config/certmanager/kustomization.yaml
./config/prometheus/kustomization.yaml
./config/scorecard/kustomization.yaml

@ytsarev makes sense, we get back to installations via manifests when needed, no need to have whole boilerplate

@somaritane somaritane requested a review from ytsarev March 22, 2021 09:20
@somaritane
Copy link
Contributor Author

@ytsarev removed config/ with manifest leftovers from Operator SDK, please check

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@somaritane somaritane merged commit 38171aa into master Mar 22, 2021
@somaritane somaritane deleted the remove-kustomize branch March 22, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants