Describe testing setup with k3d config #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
kuritka
reviewed
Apr 13, 2021
k0da
force-pushed
the
k3d_config
branch
2 times, most recently
from
9ad0f7e to
1974e67
Compare
ytsarev
requested changes
Apr 13, 2021
kuritka
requested changes
Apr 13, 2021
ytsarev
requested changes
Apr 13, 2021
We have more places where configuration is repeated. Lets describe it by k3d config and reuse everywhere we can. Signed-off-by: Dinar Valeev <[email protected]>
kuritka
approved these changes
Apr 13, 2021
ytsarev
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have more places where configuration is repeated. Lets describe it by
k3d config and reuse everywhere we can.
Signed-off-by: Dinar Valeev [email protected]