Terratest timeout 15 min, parallel 12 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Apr 19, 2021
It happened that long running test `TestK8gbBasicRoundRobinExample` didn't finish [during 10 minutes](https://github.com/AbsaOSS/k8gb/pull/450/checks?check_run_id=2380389415#step:7:3939) From what I see in the logs, test started in 4th minute of terratest (some terratests already passed). `TestK8gbBasicRoundRobinExample` was not able to scale GSLB in the last phase of test and was waiting, while timeout occured. see: [text log](https://pipelines.actions.githubusercontent.com/fdhui6E3r0qyGjKGI7JL2oBgou8JslTAp47a0VPoFebyddvI6q/_apis/pipelines/1/runs/4893/signedlogcontent/3?urlExpires=2021-04-19T12%3A28%3A36.7191880Z&urlSigningMethod=HMACV1&urlSignature=Dv0kIy48JHrB0wGt8ueUp90%2FtisqMuQ8w4QHV2dr5b4%3D) I saw this behavior first time. - Regarding documentation I extended [timeout to 12m](https://terratest.gruntwork.io/docs/testing-best-practices/timeouts-and-logging/). Signed-off-by: kuritka <[email protected]> Update Makefile 12min to 15min Co-authored-by: Yury Tsarev <[email protected]>
kuritka
force-pushed
the
terratest-timeout-12m
branch
from
747b71e to
707f57c
Compare
ytsarev
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened that long running test
TestK8gbBasicRoundRobinExampledidn't finish during 10 minutes terratest run.We are running tests in Parallel. The maximum number of tests to run simultaneously is by default set to the value of GOMAXPROCS (the number of CPU's visible to the program startup). That's why tests are running in smaller parallel chunks (waves).
From what I see in the logs,
TestK8gbBasicRoundRobinExamplestarted in 4th minute of terratest (n-th wave) and was not fast enough to scale-up GSLB in the last subtest(subtests are sequential in the scope of test), TheTestK8gbBasicRoundRobinExampletimeouted see: text logI saw this behavior first time.
I shorten terratest run from usual 9+ to 6+ minutes
10 minutes limit can exceed quickly !!
Signed-off-by: kuritka [email protected]