Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for k8gb.io mixed content warnings #488

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

somaritane
Copy link
Contributor

Fixing mixed content warnings on visiting k8gb.io website:

Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/MluFlwPFZws/hqdefault.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):2 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/5pe3ezSnVI8/hqdefault.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):2 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/5DhO9C2NCrk/0.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):2 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/jeUeRQM-ZyM/0.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):1 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/MluFlwPFZws/hqdefault.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):1 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/5pe3ezSnVI8/hqdefault.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):1 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/5DhO9C2NCrk/0.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
(index):1 Mixed Content: The page at 'https://www.k8gb.io/' was loaded over HTTPS, but requested an insecure element 'http://img.youtube.com/vi/jeUeRQM-ZyM/0.jpg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html

https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content/How_to_fix_website_with_mixed_content

Signed-off-by: Timofey Ilinykh [email protected]

@somaritane somaritane added the bug Something isn't working label May 13, 2021
@somaritane somaritane added this to the 0.9 milestone May 13, 2021
@somaritane somaritane requested review from ytsarev, k0da and kuritka May 13, 2021 08:48
@somaritane somaritane requested a review from donovanmuller as a code owner May 13, 2021 08:48
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watching github preview and would be nice to align,
Consider central alignment:

| Tables   |      Are      |  Cool |
|----------|:-------------:|------:|
| col 1 is |  left-aligned | $1600 |
| col 2 is |    centered   |   $12 |
| col 3 is | right-aligned |    $1 |

@somaritane
Copy link
Contributor Author

Watching github preview and would be nice to align,
Consider central alignment:

| Tables   |      Are      |  Cool |
|----------|:-------------:|------:|
| col 1 is |  left-aligned | $1600 |
| col 2 is |    centered   |   $12 |
| col 3 is | right-aligned |    $1 |

@kuritka amended, also using a compact format from www.tablesgenerator.com/markdown_tables to make markdown looking simpler in editor.

@somaritane somaritane requested a review from kuritka May 13, 2021 09:39
@somaritane somaritane merged commit d67958f into master May 13, 2021
@somaritane somaritane deleted the k8gb-io-mixed-content-fix branch May 13, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants