refactor (1/3): simplify controller tests #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I'm removing config settings through environment variables in controller_tests. Such functionality is covered by depresolver tests and thanks to that I'm simplifying `provideSettings` function. Also introducing new property will not require to set environment variables in two places. - In order to rename interfaces (#491) I'm regenerating mocks to get new names. Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
reviewed
May 24, 2021
|
@ytsarev yes and no. We resolve env vars in main() func while controller (or better reconciler) accepts ready-made configuration. It still happens in main() func. The same we did in controller_tests. Set envvars, read them, pass to reconciler, factory, etc. At the end, the test started. From my POV we can pass configuration directly to controller with no envvars manipulation. Envvars manipulation itself is covered by depresolver tests. |
ytsarev
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm removing config settings through environment variables in controller_tests.
Depresolver tests already cover such functionality. Thanks to that I'm simplifying
provideSettingsfunction.Also, introducing new property will not require setting environment variables
in two places.
In order to rename interfaces (refactor: interface rename #491) I'm regenerating mocks to get new names.
Signed-off-by: kuritka [email protected]