Metrics configuration #(1/4) #525
Conversation
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
|
@kuritka this is a bit confusing. 9090 is a default p8s server port. 8080 and MetricsAddr was pretty self explanatory term. |
Ok, will change to 8080. What do you mean by MetricsAddr ? |
|
@kuritka you have it now as Prometheus.Port (sounds like server port), MetricsAddr defines metrics endpoint better IMO |
kuritka
force-pushed
the
prometheus2
branch
3 times, most recently
from
bf4a0c5 to
f3e9075
Compare
kuritka
force-pushed
the
prometheus2
branch
2 times, most recently
from
ad6e895 to
92f5a43
Compare
| Port: 9443, | ||
| LeaderElection: enableLeaderElection, | ||
| LeaderElection: false, |
There was a problem hiding this comment.
hmm, we never tested it, but what if somebody would like to try to execute multiple k8gb controllers with leader election mechanism in the future? currently it is optional but here it is becoming hardcoded.
There was a problem hiding this comment.
enableLeaderElection was accessible through an argument of executable. Making such functionality available would mean passing the argument to the controller pod. Till now it was always false anyway.
What we can do is create an issue, expose an environment variable and test.
There was a problem hiding this comment.
@kuritka ok let's log the issue then
There was a problem hiding this comment.
even more, I think it requires to have locking to be implemented.
Related to #124 I created a MetricsAddress field. The default port value is “0.0.0.0:8080" and defines where Prometheus metrics endpoint is listening. (see: https://docs.openshift.com/container-platform/4.1/applications/operator_sdk/osdk-monitoring-prometheus.html#osdk-monitoring-prometheus-metrics-helper_osdk-monitoring-prometheus) I also removed flag.StringVar `"metrics-addr", ":8080”,` from `main.go` as moving inputs into depresolver and also, removed enableLeaderElection and overall flags completely. Signed-off-by: kuritka <[email protected]>
Related to #124
I created a MetricsAddress field. The default value is “0.0.0.0:8080" and defines where Prometheus metrics endpoint is listening. (see: https://docs.openshift.com/container-platform/4.1/applications/operator_sdk/osdk-monitoring-prometheus.html#osdk-monitoring-prometheus-metrics-helper_osdk-monitoring-prometheus)
I also removed flag.StringVar
"metrics-addr", ":8080”,frommain.goas moving inputs into depresolver and also, removedenableLeaderElectionand overall flags completely.Signed-off-by: kuritka [email protected]