Handling error code for defer functions #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #124 because of the metrics we have to run the deferred function even if an error occurred during main processing. Until now, we used to call `os.Exit(1)` in main if any error occurred. Unfortunately, `os.exit` skips the deferred function call. The solution is implementation. In case of an error we call `return` instead of `os.Exit`, and `os.Exit` itself is a deferred function. goimports made some changes in terratest Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
|
@ytsarev , thx. Yes it's inherited from generated code which doesn't contain any deferred functions. But yes, we can try to push upstream as template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #124
because of the metrics we have to run the deferred function even if an error occurred during main processing. Until now, we used to call
os.Exit(1)in main if any error occurred. Unfortunately,os.exitskips the deferred function call.The solution is implementation. In case of an error we call
returninstead ofos.Exit, andos.Exititself is a deferred function.