K8gbEndpointStatus #620
Merged
K8gbEndpointStatus #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
previously approved these changes
Sep 15, 2021
k0da
previously approved these changes
Sep 15, 2021
|
kuritka
force-pushed
the
metrics-extensions
branch
from
156402a to
411f9f6
Compare
|
@somaritane , thx, |
@kuritka sorry for missing this earlier, I guess |
related to #587 `k8gb_endpoint_status_num`, the metric provides information about the number of targets in DNSEndpoint. ```shell k8gb_endpoint_status{dns_name="failover.cloud.example.com", exported_name="test-gslb-failover", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="localtargets-failover.cloud.example.com", exported_name="test-gslb-failover", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="localtargets-roundrobin.cloud.example.com", exported_name="test-gslb", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="roundrobin.cloud.example.com", exported_name="test-gslb", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 4 ``` --- In addition: - I moved the linter test from `gslb_controller_test` to `prometheus_test`. - according to #587 the request was to rename one of the metrics to `k8gb_gslb_service_status_count,`. Unfortunately, this metric is GaugeVec and the linter does not allow to use the `_count` or `_total` suffix (they are reserved for counters). Therefore I renamed the metric to `k8gb_gslb_service_status_num,` Signed-off-by: kuritka <[email protected]>
kuritka
force-pushed
the
metrics-extensions
branch
from
411f9f6 to
681e575
Compare
|
@somaritane amended, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #587
k8gb_endpoint_status, the metric provides information about the number of targets in DNSEndpoint.k8gb_endpoint_status{dns_name="failover.cloud.example.com", exported_name="test-gslb-failover", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="localtargets-failover.cloud.example.com", exported_name="test-gslb-failover", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="localtargets-roundrobin.cloud.example.com", exported_name="test-gslb", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 2 k8gb_endpoint_status{dns_name="roundrobin.cloud.example.com", exported_name="test-gslb", instance="10.42.0.6:8080", job="kubernetes-pods", kubernetes_namespace="k8gb", kubernetes_pod_name="k8gb-7f5564d48b-xtt4w", name="k8gb", namespace="test-gslb", pod_template_hash="7f5564d48b"} | 4In addition:
gslb_controller_testtoprometheus_test.k8gb_gslb_service_status_count,. Unfortunately, this metric is GaugeVec and the linter does not allow to use the_countor_totalsuffix (they are reserved for counters). Therefore I renamed the metric tok8gb_gslb_service_status,Signed-off-by: kuritka [email protected]