Make securityContext of the deployment fully configurable #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Sep 30, 2021
ytsarev
requested changes
Sep 30, 2021
jkremser
force-pushed
the
helm-securityContext
branch
from
2bbba52 to
e61f18c
Compare
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
force-pushed
the
helm-securityContext
branch
from
e61f18c to
b993d16
Compare
ytsarev
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: aligning the logic w/ the coredns helm chart (upstream version), this will allow for more flexibility on platforms like OpenShift (changing fsGroup, selinux, seccomp profile and what not)
btw. if one wants to remove the
runAsUser: 1000(which is set by default) from the resulting yamls, they can set the value explicitly tonullSigned-off-by: Jirka Kremser [email protected]