Remove FAKE_INFOBLOX (2/3) #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
remove-FAKE_INFOBLOX
branch
from
8d728d1 to
89e1408
Compare
|
Ah, you mentioned it, sorry :) |
This is a follow-up PR to #630 (1/3), do not review until #630 is merged Everything is now being mocked up, there is no need to distinguish between local and production infoblox. Bool switch no longer makes sense, removing Signed-off-by: kuritka <[email protected]>
kuritka
force-pushed
the
remove-FAKE_INFOBLOX
branch
from
89e1408 to
ff5b927
Compare
ytsarev
approved these changes
Oct 2, 2021
k0da
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #630 (1/3), do not review until #630 is merged.
Everything is now being mocked up, there is no need to distinguish between local and production infoblox.
Bool switch no longer makes sense, removing
Signed-off-by: kuritka [email protected]