Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use PNG image as chart icon (#671)" #675

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Revert "Use PNG image as chart icon (#671)" #675

merged 1 commit into from
Oct 21, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Oct 21, 2021

This reverts commit a3929b1.

@k0da
Revert "Use PNG image as chart icon (#671)"
0d0dcb9 
This reverts commit a3929b1.

Signed-off-by: Dinar Valeev <[email protected]>
@jkremser
Copy link
Member

Having svg file there blocks the integration with olm-bundle convertor (see upbound/olm-bundle#17) @somaritane what do you suggest as a solution here?

@somaritane
Copy link
Contributor

somaritane commented Oct 21, 2021 •
edited
Loading

Having svg file there blocks the integration with olm-bundle convertor (see upbound/olm-bundle#17) @somaritane what do you suggest as a solution here?

@jkremser My understanding was that the root cause of the issue with olm-bundle convertor was in odd <?xml version="1.0" encoding="utf-8"?> preamble in https://raw.githubusercontent.com/cncf/artwork/master/projects/k8gb/icon/color/k8gb-icon-color.svg asset.
But looks like this isn't the case (sorry, didn't follow the internal conversation)

The solution might be to get the png asset, resize it and publish in
https://github.com/k8gb-io/k8gb/tree/gh-pages/assets/images, so it can be consumed either as:
https://raw.githubusercontent.com/k8gb-io/k8gb/gh-pages/assets/images/chart-icon.png
or as https://www.k8gb.io/assets/images/chart-icon.png (as it will be published asset)

@k0da k0da merged commit e84963b into master Oct 21, 2021
@k0da k0da deleted the png branch October 21, 2021 13:45
@somaritane somaritane mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somaritane somaritane somaritane approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k0da @jkremser @somaritane