Add a way to use non-released changes in repo for producing an olm bundle #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle This will allow for hot-fixing in case some files are missing/out-of-sync with those inputs for the olm-bundle generation process: 1) Chart.yaml 2) helm chart itself 3) templates for the olm-bundle tool (stuff under /olm/*) Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
k0da
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for hot-fixing in case some files are missing/out-of-sync
with those inputs for the olm-bundle generation process:
/olm/*)That's actually currently happening, the release
0.8.3was done w/o the files necessary for the olm-bundle automation to be in place. The GHA is currently done in a way that it takes the latest released tag (if not provided explicitly) and checks out the repo into that state... but the files are not there so it fails.This PR adds more flexibility. If the version is set to
masterit will not check out the release tag and use the current tip of the repo for the action.note: the action is failing only because it's running against the latest release that doesn't have the needed files, if the next release is done, it would work also without this change, but again there would be no way to hot-fix a typo or anything without making a new release and only then be able to do the olm bundle.
Signed-off-by: Jirka Kremser [email protected]