olm: fix paths in the resulting PR #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
approved these changes
Nov 1, 2021
k0da
reviewed
Nov 1, 2021
| @@ -43,12 +43,11 @@ jobs: | |||
| - name: Generate OLM bundle | |||
| env: | |||
| TOOL_VERSION: ${{ github.event.inputs.olmBundleToolVersion }} | |||
| PREVIOUS_VERSION: "v0.0.1" # remove me after the pr on community-operators repo is merged | |||
There was a problem hiding this comment.
the pr w/ 0.8.3 got merged so for the next release this value will be calculated as "the last but one release"
k0da
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paths were not ok, check the resulting pr.
It created
operators/k8gb/0.8.3/bundle/manifestsinstead of
operators/k8gb/0.8.3/manifestsAlso fixing the wrong path in url that's put on the PR description (the link was broken)
Sorry for spam :)
Signed-off-by: Jirka Kremser [email protected]