Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop resolv.conf hack #764

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Drop resolv.conf hack #764

merged 1 commit into from
Nov 23, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Nov 19, 2021

This commit drops resolv.conf hack and uses POD's dnsConfig instead

Signed-off-by: Dinar Valeev [email protected]

@k0da k0da force-pushed the busyBox_dnsConfig branch 13 times, most recently from 68fcec2 to 44fa775 Compare November 23, 2021 00:23
@k0da k0da marked this pull request as ready for review November 23, 2021 00:38
ytsarev
ytsarev previously approved these changes Nov 23, 2021
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

* This commit drops resolv.conf hack and uses POD's dnsConfig instead

Signed-off-by: Dinar Valeev <[email protected]>
@jkremser
Copy link
Member

Fixes #712 (nice change)

@k0da k0da requested a review from jkremser November 23, 2021 09:08
@k0da k0da merged commit f2729ad into k8gb-io:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants