Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignoring file called 'changes' that's produced and consumed by goreleaser #778

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jkremser
Copy link
Member

This entry was removed from the .gitignore recently, but it needs to be there for the release process to finish w/o errors.

We create the file here: https://github.com/k8gb-io/k8gb/blob/master/.github/workflows/release.yaml#L27

and consume it within the same action couple of steps later here: https://github.com/k8gb-io/k8gb/blob/master/.github/workflows/release.yaml#L49

But if it's not ignored, the goreleaser fails on this issue: https://github.com/k8gb-io/k8gb/runs/4372363917?check_suite_focus=true#step:8:23
because the git is in dirty state (there are untracked files). Other workaround would be copying that file somewhere else on that filesystem, but it's imho better to .gitignore it as it was before.

Signed-off-by: Jirka Kremser [email protected]

@jkremser
Copy link
Member Author

jkremser commented Nov 30, 2021

upgrade testing will be failing until the release is reverted (the 0.8.5 tag is there in the git repo, but container image is not there on dockerhub)

@jkremser jkremser merged commit 997d652 into k8gb-io:master Nov 30, 2021
@jkremser jkremser deleted the gitignore-changes branch November 30, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants