workflow optimization #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #840 skipping already finished workflows, NOT concurrent (different PR) I've been doing investigations about canceling workflows (https://github.com/fkirc/skip-duplicate-actions). The action works by checking in pre_job whether the pipe has already been run. Then in the main job there is a condition that either continues processing or skips the job. This results in ALWAYS running all workflows, even duplicate ones. The difference is that the duplicates will terminate at a different point. We will still see a lot of green runs. It's a bit different than I imagined (not starting or CANCEL the duplicate at all). I found out that I can cancel the workflow programmatically via HTTP POST. So if we create different custom ction, we can cancel on top and probably delete cancelled job. Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
jkremser
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #840
skipping already finished workflows, NOT concurrent (different PR). See skip detail.
I've been doing investigations about canceling workflows (https://github.com/fkirc/skip-duplicate-actions). The action works by checking in pre_job whether the pipe has already been run. Then in the main job there is a condition that either continues processing or skips the job.
This results in ALWAYS running all workflows, even duplicate ones. The difference is that the duplicates will terminate at a different point. We will still see a lot of green runs.
It's a bit different than I imagined (not starting or CANCEL the duplicate at all).
I found out that I can cancel the workflow programmatically via HTTP POST.
So if we create custom action, we can cancel on top of workflow and probably delete
cancelled job from workflows page. Such behaviour would be more expected.
Signed-off-by: kuritka [email protected]