Bump goreleaser action and goreleaser itself #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
k0da
approved these changes
Jun 23, 2022
kuritka
pushed a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Jirka Kremser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixing #904
Can't say for 100% because it's a non-deterministic issue that might be also caused by container registries (when pulling the base image), rate limiters, running on different VMs, etc. Currently the error is kinda swallowed by the goreleaser.
I ran the terratest and upgrade tests workflows (
terratest.yaml&upgrade-testing.yaml) each 8 times and haven't seen any container build failures. Only once the terratests failed on this, but that's the race condition issue, not the container build thingy.update1: well, 9 times including the build of this pr (because I rebased on master and "
push-fed")update2: haha, so the last build failed so it's not fixing the issue, but the bump can't hurt right?
Signed-off-by: Jirka Kremser [email protected]