Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etcd-operator as own subchart #94

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Etcd-operator as own subchart #94

merged 2 commits into from
Apr 21, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 20, 2020

kuritka
kuritka previously approved these changes Apr 20, 2020
kuritka
kuritka previously approved these changes Apr 20, 2020
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ytsarev , just quick question; Why did you remove pull request execution ?

somaritane
somaritane previously approved these changes Apr 20, 2020
@ytsarev
Copy link
Member Author

ytsarev commented Apr 20, 2020

Hi @ytsarev , just quick question; Why did you remove pull request execution ?

@kuritka [push, pull_request] event list resulted in duplicated twice execution of the same jobs for the same commit

@ytsarev
Copy link
Member Author

ytsarev commented Apr 20, 2020

@kuritka to be more illustrative - that's why :
image

ytsarev added 2 commits April 21, 2020 14:18
* Move etcd-operator to own subchart because upstream merge
  of helm/charts#20084 looks pretty much
  hopeless
* Bump and sync chart version as per maintainers agreement
* Occasional trailing whitespace removal
@ytsarev ytsarev dismissed stale reviews from somaritane and kuritka via ffdd20a April 21, 2020 12:19
@ytsarev ytsarev requested review from somaritane and kuritka April 21, 2020 13:30
@ytsarev ytsarev merged commit 652c203 into master Apr 21, 2020
@ytsarev ytsarev deleted the ohmyetcdoperator branch April 21, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants