Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial operator metrics #97

Merged
merged 10 commits into from
May 12, 2020
Merged

Initial operator metrics #97

merged 10 commits into from
May 12, 2020

Conversation

somaritane
Copy link
Contributor

@somaritane somaritane commented Apr 23, 2020 •
edited
Loading

  • Resolves Expose metrics and tracing #47 with initial creation of OhMyGLB specific metrics.
  • Following custom metrics are added:
    • healthy_records
    • managed_hosts
  • Documentation updated in order to cover metric types exposed by operator (extended controller-runtime metrics and kube-state-metrics)

@donovanmuller
Copy link
Contributor

@somaritane Would it be possible to provide a simple sample Grafana dashboard showing off the existing metrics with a complimentary visualisation?

ytsarev
ytsarev reviewed Apr 23, 2020
View reviewed changes
ytsarev
ytsarev reviewed Apr 23, 2020
View reviewed changes
ytsarev
ytsarev requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • So we agreed to make delve optional
  • Also we need to discuss unit test strategy of metric related functions before we proceed

@somaritane somaritane force-pushed the custom-operator-metrics branch from 69212e2 to 5c32c9b Compare April 27, 2020 08:42
@somaritane somaritane force-pushed the custom-operator-metrics branch from 5c32c9b to 5054df5 Compare May 11, 2020 08:29
@somaritane somaritane requested a review from ytsarev May 11, 2020 09:02
ytsarev
ytsarev reviewed May 11, 2020
View reviewed changes
ytsarev
ytsarev requested changes May 11, 2020
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider following modifications:

  • Total related renames.
  • t.Helper() to test help functions

@somaritane somaritane requested a review from ytsarev May 12, 2020 06:56
ytsarev
ytsarev approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes and overall outstanding job!

Special kudos for test suite enhancement with helper functions and test case isolation \m/

@ytsarev ytsarev merged commit dfe5131 into master May 12, 2020
@ytsarev ytsarev deleted the custom-operator-metrics branch May 12, 2020 10:53
This was referenced May 13, 2020
Closed
Closed
@somaritane somaritane mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose metrics and tracing
4 participants
@somaritane @donovanmuller @ytsarev @kuritka