inject init-container secrets webhook #944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 57.64% 57.78% +0.14%
==========================================
Files 96 96
Lines 9446 9462 +16
==========================================
+ Hits 5445 5468 +23
+ Misses 3542 3537 -5
+ Partials 459 457 -2
|
|
closing after discussion on 4/20/23. The webhook itself will be configurable rather than injecting an init-container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes the default secrets-webhook to inject an init-container into each pod that is eligible for mutation through the secrets injection annotation. The webhook will insert the init-container into the first position of each pod since some init-containers might depend on the credentials being available on the local filesystem (e.g. medusa restores). By default, the webhook will inject the
k8ssandra/k8ssandra-clientimage, which will have a mount command to process the annotation string, retrieving and mounting the secrets to the specified path. If a user wants to use their own custom image, they can set the annotationk8ssandra.io/inject-secret-imagewith the image name. The custom image must be compatible with the args["mount", {secretInjection}"]Which issue(s) this PR fixes:
Fixes #605
Checklist