enhance: wrapped entry values into variables in tests

kabocha-network · Aug 1, 2022 · 7a52638 · 7a52638
1 parent ec92f11
commit 7a52638
Showing 1 changed file with 88 additions and 24 deletions.
diff --git a/src/tests/subscribe.rs b/src/tests/subscribe.rs
@@ -37,44 +37,84 @@ fn subscribe() {
 #[test]
 fn subscribe_multiple_events() {
 	ExternalityBuilder::build().execute_with(|| {
+		const ALICE: u64 = 1;
+		const BOB: u64 = 2;
+		let amount = 4000;
+		let frequency = 5;
+		let number_of_installment = Some(4);
+
 		assert_ok!(PalletSubscription::subscribe(
-			Origin::signed(1),
-			2,
-			4000,
-			5,
-			Some(4)
+			Origin::signed(ALICE),
+			BOB,
+			amount,
+			frequency,
+			number_of_installment
 		));
 
-		let expected_event = Event::PalletSubscription(crate::Event::Subscription(2, 1, 4000, 5));
-		assert_eq!(System::events()[0].event, expected_event);
+		let expected_event =
+			Event::PalletSubscription(crate::Event::Subscription(BOB, ALICE, amount, frequency));
+		let received_event = &System::events()[0].event;
+
+		assert_eq!(*received_event, expected_event);
+
+		const PAUL: u64 = 7;
+		const JANE: u64 = 10;
+		let amount = 6000;
+		let frequency = 7;
+		let number_of_installment = Some(4);
 
 		assert_ok!(PalletSubscription::subscribe(
-			Origin::signed(7),
-			10,
-			6000,
-			7,
-			Some(4)
+			Origin::signed(PAUL),
+			JANE,
+			amount,
+			frequency,
+			number_of_installment
 		));
-		let expected_event = Event::PalletSubscription(crate::Event::Subscription(10, 7, 6000, 7));
-		assert_eq!(System::events()[1].event, expected_event);
+
+		let expected_event =
+			Event::PalletSubscription(crate::Event::Subscription(JANE, PAUL, amount, frequency));
+		let received_event = &System::events()[1].event;
+
+		assert_eq!(*received_event, expected_event);
+
+		const MIKE: u64 = 8;
+		const ASHLEY: u64 = 11;
+		let amount = 6001;
+		let frequency = 8;
+		let number_of_installment = Some(4);
 
 		assert_ok!(PalletSubscription::subscribe(
-			Origin::signed(8),
-			11,
-			6001,
-			8,
-			Some(4)
+			Origin::signed(MIKE),
+			ASHLEY,
+			amount,
+			frequency,
+			number_of_installment
 		));
-		let expected_event = Event::PalletSubscription(crate::Event::Subscription(11, 8, 6001, 8));
-		assert_eq!(System::events()[2].event, expected_event);
+		let expected_event =
+			Event::PalletSubscription(crate::Event::Subscription(ASHLEY, MIKE, amount, frequency));
+		let received_event = &System::events()[2].event;
+
+		assert_eq!(*received_event, expected_event);
 	})
 }
 
 #[test]
 fn subscribe_frequency_zero() {
 	ExternalityBuilder::build().execute_with(|| {
+		const ALICE: u64 = 1;
+		const BOB: u64 = 2;
+		let amount = 400;
+		let frequency = 0;
+		let number_of_installment = Some(4);
+
 		assert_noop!(
-			PalletSubscription::subscribe(Origin::signed(1), 2, 400, 0, Some(4)),
+			PalletSubscription::subscribe(
+				Origin::signed(ALICE),
+				BOB,
+				amount,
+				frequency,
+				number_of_installment
+			),
 			Error::<TestRuntime>::InvalidSubscription
 		);
 	})
@@ -83,8 +123,20 @@ fn subscribe_frequency_zero() {
 #[test]
 fn subscribe_amount_zero() {
 	ExternalityBuilder::build().execute_with(|| {
+		const ALICE: u64 = 8;
+		const BOB: u64 = 11;
+		let amount = 0;
+		let frequency = 5;
+		let number_of_installment = Some(4);
+
 		assert_noop!(
-			PalletSubscription::subscribe(Origin::signed(1), 2, 0, 5, Some(4)),
+			PalletSubscription::subscribe(
+				Origin::signed(ALICE),
+				BOB,
+				amount,
+				frequency,
+				number_of_installment
+			),
 			Error::<TestRuntime>::InvalidSubscription
 		);
 	})
@@ -93,8 +145,20 @@ fn subscribe_amount_zero() {
 #[test]
 fn subscribe_amount_frequency_zero() {
 	ExternalityBuilder::build().execute_with(|| {
+		const ALICE: u64 = 1;
+		const BOB: u64 = 2;
+		let amount = 0;
+		let frequency = 0;
+		let number_of_installment = Some(4);
+
 		assert_noop!(
-			PalletSubscription::subscribe(Origin::signed(1), 2, 0, 0, Some(4)),
+			PalletSubscription::subscribe(
+				Origin::signed(ALICE),
+				BOB,
+				amount,
+				frequency,
+				number_of_installment
+			),
 			Error::<TestRuntime>::InvalidSubscription
 		);
 	})