The era of Deno begins #364
Conversation
Import and closes #208
…ot support *.css importing And the HMR is actually not working for CSS, we really need browser reloading when it is using tsx
|
Visit the preview URL for this PR (updated for commit 98b7310): https://color-json-terminal-and-vscode--pr364-deno-retry2-2t8f8ixv.web.app (expires Mon, 15 May 2023 10:50:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59eb6df3715ec61e9434b8c55d6f326add5e081a |
| - selector: TSEnumDeclaration | ||
| message: Don't declare enums. | ||
| prettier/prettier: 'off' | ||
| no-mixed-operators: error |
There was a problem hiding this comment.
Many options does not exists on deno lint, but brazing fast ⚡ 🙄
| "printWidth": 120, | ||
| "singleQuote": true | ||
| }, | ||
| "includes": ["**/*.{ts,tsx,js,jsx,cjs,mjs,json,md,yml,html}"], |
There was a problem hiding this comment.
I would use some formatter for YAML 🤔
| import { useState } from 'react'; | ||
| import './App.css'; | ||
| import { safeConvertWindowsTerminalToVSCode } from './converter'; | ||
| import React, { useState } from 'https://esm.sh/[email protected]'; |
There was a problem hiding this comment.
Without React, jsx/tsx does not work in vscode
| import App from './App'; | ||
| import './index.css'; | ||
| import { assertIsDefined } from './typeguards'; | ||
| /// <reference lib="dom"/> |
There was a problem hiding this comment.
For document.getElementById
| import { StrictMode } from 'react'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import App from './App'; | ||
| import './index.css'; |
There was a problem hiding this comment.
Importing CSS is not supported in deno typecheck. It was the big blocker 😢
|
|
||
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| plugins: [react()], |
There was a problem hiding this comment.
When deno check, this is not callable 🤔
Import and closes #208