-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default.nix for building chainweb-node on machines without SSE #1538
Conversation
I can confirm that this PR builds and passes tests on my Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the SSE build error I was getting on Linux.
It seems that M1 Mac has problems building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on multiple Linux machines.
Just to note, there is some patching being done in the Nix file that should be applied to the Cabal file and the source directly. Since that is a more invasive approach that affects all users, I will take that up in a separate PR. |
Fixes #1537