Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default.nix for building chainweb-node on machines without SSE #1538

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

jwiegley
Copy link
Collaborator

Fixes #1537

@jwiegley jwiegley self-assigned this Sep 24, 2022
@jwiegley
Copy link
Collaborator Author

I can confirm that this PR builds and passes tests on my Mac.

@mightybyte mightybyte changed the title Fix default.nix for building chainweb-node on macOS Fix default.nix for building chainweb-node on machines without SSE Sep 28, 2022
Copy link
Contributor

@mightybyte mightybyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the SSE build error I was getting on Linux.

@jwiegley
Copy link
Collaborator Author

It seems that M1 Mac has problems building tbb that rocksdb-haskell depends on. It is addressed in this issue, so working on the patch now: uxlfoundation/oneTBB#186

Copy link
Contributor

@emmanueldenloye emmanueldenloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mightybyte mightybyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on multiple Linux machines.

@jwiegley jwiegley merged commit b64db9c into master Sep 29, 2022
@jwiegley jwiegley deleted the johnw/mac-nix branch September 29, 2022 15:45
@jwiegley
Copy link
Collaborator Author

Just to note, there is some patching being done in the Nix file that should be applied to the Cabal file and the source directly. Since that is a more invasive approach that affects all users, I will take that up in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rocksdb-haskell-kadena dependency does not build on macOS
3 participants