This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Remove unused knobs from panel #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roonyh
force-pushed
the
dynamic-knobs
branch
3 times, most recently
from
6a84aee to
087f6c0
Compare
When a story re-renders if a certain knob is not used that will be removed from the panel. When it is used again its added back. See example story named `dynamic knobs` for an example.
|
@arunoda, Made the discussed changes |
|
Okay. This looks great for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a story re-renders if a certain knob is not used that will be removed from the panel. When it is used again its added back.
See example story named
dynamic knobsfor an example.