Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic knobs #3464

Closed
wants to merge 3 commits into from
Closed

Fix dynamic knobs #3464

wants to merge 3 commits into from

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Apr 21, 2018

Issue: #2661 accidentally broke "dynamic knobs" feature (storybook-eol/storybook-addon-knobs#59)

How to test

Open dynamic knobs story, select "no". Optionsl knob should disappear

@Hypnosphi Hypnosphi added bug addon: knobs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 21, 2018
# Conflicts:
#	examples/official-storybook/stories/__snapshots__/addon-knobs.stories.storyshot
@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@da5fdef). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3464   +/-   ##
=========================================
  Coverage          ?   37.23%           
=========================================
  Files             ?      464           
  Lines             ?    10289           
  Branches          ?      932           
=========================================
  Hits              ?     3831           
  Misses            ?     5909           
  Partials          ?      549
Impacted Files Coverage Δ
addons/knobs/src/components/Panel.js 73.61% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5fdef...e0c7a93. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team April 27, 2018 01:24
@shilman
Copy link
Member

shilman commented May 4, 2018

@Hypnosphi this PR doesn't seem to contain any changed files, but there are non-empty commits. Is this a github bug?

@Hypnosphi
Copy link
Member Author

Hypnosphi commented May 4, 2018

Looks like it's merged as a part of #3465
It would still make sense to cherry-pick d2a289e to release/3.4, will do that

@Hypnosphi Hypnosphi closed this May 4, 2018
@Hypnosphi Hypnosphi deleted the fix-dynamic-knobs branch May 4, 2018 01:08
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants