Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostAliases to template #11

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Add hostAliases to template #11

merged 2 commits into from
Apr 20, 2024

Conversation

isak-lindbeck
Copy link
Contributor

This enables hostAliases to be configured.
https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/

Is for example useful when working with a sidecard proxy. The values configuration could look something like this:

hostAliases:
  - ip: "127.0.0.1"
    hostnames:
      - "schema-registry.localhost"

@isak-lindbeck isak-lindbeck requested a review from a team as a code owner April 19, 2024 11:55
Copy link
Member

@azatsafin azatsafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
The feature and code is OK, need to make some internal Job to define Helm Chart versioning before merge.

@Haarolean Haarolean added the type/enhancement En enhancement/improvement to an already existing feature label Apr 20, 2024
@Haarolean Haarolean merged commit 49d51d2 into kafbat:main Apr 20, 2024
1 check passed
@Haarolean
Copy link
Member

@isak-lindbeck thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants