Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type spec of v2 group consumer handle_message #571

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

chsukivra
Copy link
Contributor

Given that brod_topic_subscriber callback is typed as below and brod_group_subscriber_worker implements brod_topic_subscriber, it will pass on brod:message_set to v2 group consumers.

-callback handle_message(brod:partition(),
                         brod:message() | brod:message_set(),
                         cb_state()) -> cb_ret().

So the brod_group_subscriber_v2 behavior should probably be typed to be either message or message_set too.

@zmstone zmstone merged commit 9781a71 into kafka4beam:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants