Refactor eest blockchain test flow

blockchain/chain_makers.go

@@ -102,6 +102,8 @@ func (b *BlockGen) AddTxWithChain(bc *BlockChain, tx *types.Transaction) {
 	b.receipts = append(b.receipts, receipt)
 }
 
+// AddTxWithChainEvenHasError is an AddTx that inherits the vmConfig of the received chain
+// and does not panic even if an error occurs.
 func (b *BlockGen) AddTxWithChainEvenHasError(bc *BlockChain, tx *types.Transaction) error {
 	b.statedb.SetTxContext(tx.Hash(), common.Hash{}, len(b.txs))
 	var vmConfig vm.Config

tests/block_test.go

@@ -29,30 +29,6 @@ import (
 	"github.com/stretchr/testify/suite"
 )
 
-func TestBlockchain(t *testing.T) {
-	t.Parallel()
-
-	bt := new(testMatcher)
-	// General state tests are 'exported' as blockchain tests, but we can run them natively.
-	bt.skipLoad(`^GeneralStateTests/`)
-	// Skip random failures due to selfish mining test.
-	// bt.skipLoad(`^bcForgedTest/bcForkUncle\.json`)
-	bt.skipLoad(`^bcMultiChainTest/(ChainAtoChainB_blockorder|CallContractFromNotBestBlock)`)
-	bt.skipLoad(`^bcTotalDifficultyTest/(lotsOfLeafs|lotsOfBranches|sideChainWithMoreTransactions)`)
-	// This test is broken
-	bt.fails(`blockhashNonConstArg_Constantinople`, "Broken test")
-
-	// Still failing tests
-	// bt.skipLoad(`^bcWalletTest.*_Byzantium$`)
-
-	// TODO-Kaia Update BlockchainTests first to enable this test, since block header has been changed in Kaia.
-	//bt.walk(t, blockTestDir, func(t *testing.T, name string, test *BlockTest) {
-	//	if err := bt.checkFailure(t, name, test.Run()); err != nil {
-	//		t.Error(err)
-	//	}
-	//})
-}
-
 // TestExecutionSpecState runs the state_test fixtures from execution-spec-tests.
 type ExecutionSpecBlockTestSuite struct {
 	suite.Suite