Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy RebalanceTreasury and SimulatedBackend #21

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Jun 21, 2024

Proposed changes

  • Remove unused getBurnAmountMagma function
  • Relocate the treasury rebalance memo logging site from system.RebalanceTreasury to engine.Finalize
  • SimulatedBackend.SuggestGasPrice returns lastBaseFee*2 or UnitPrice depending on fork level.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29 blukat29 changed the title blockchain: Remove unused function Minor refactoring Jun 21, 2024
@blukat29 blukat29 changed the title Minor refactoring Tidy RebalanceTreasury and SimulatedBackend Jun 21, 2024
@blukat29 blukat29 merged commit 788a8be into kaiachain:dev Jun 22, 2024
11 checks passed
@blukat29 blukat29 deleted the polish-202406 branch June 22, 2024 04:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants