Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/database: cleanup old database after migration #236

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

hyeonLewis
Copy link
Contributor

Proposed changes

When the node stops while removing the old db, the state migration restarts from scratch. This PR sets the old db path before removal so the node can find a pending removal job when restarted. Inspired from #229 (comment)

Please note that PR #229 only fixes nil dereference issue.

The overall process will be:

  1. Set the completion mark and old db path.
  2. Start removing old db.
  3. The node stops before completely removing the old db.
  4. The node will find the old db path and remove it.
  5. Set empty old db path.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyeonLewis
Copy link
Contributor Author

PTAL @hyunsooda

@hyeonLewis hyeonLewis merged commit 922480b into kaiachain:dev Feb 4, 2025
11 checks passed
@hyeonLewis hyeonLewis deleted the restart-migration branch February 4, 2025 05:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants