Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload staking info only at startup #48

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Preload staking info only at startup #48

merged 10 commits into from
Jul 17, 2024

Conversation

hyeonLewis
Copy link
Contributor

@hyeonLewis hyeonLewis commented Jul 15, 2024

Proposed changes

This PR is similar with #46 except that it only regenerates and preloads staking info at node start up. The existing APIs will bubble up if user requests info at stateless block (or blocks).

How it differs from #46:

#46 This PR
Startup regen regen
APIs regen bubble up missing state error ("missing trie node")
APIs example
// No snapshot cache
> kaia.getCommittee("20")
Error: missing trie node d9c413d220797a666c786380e0f269b1f228304601cdc492c66eb40bdc2efc28 (path )
	at web3.js:6812:9(39)
	at send (web3.js:5223:62(29))
	at <eval>:1:18(3)

// No snapshot cache
> kaia.getBlockWithConsensusInfo
kaia.getBlockWithConsensusInfo kaia.getBlockWithConsensusInfoRange
> istanbul.getValidators(30)
Error: missing trie node d9c413d220797a666c786380e0f269b1f228304601cdc492c66eb40bdc2efc28 (path )
	at web3.js:6812:9(39)
	at send (web3.js:5223:62(29))
	at <eval>:1:23(3)

> kaia.getRewards("30")
Error: missing trie node 25b62b34e5d1f2b5ccc2349ff7da9a7f73abe7b154c6153ff3aa7459ba270800 (path )
	at web3.js:6812:9(39)
	at send (web3.js:5223:62(29))
	at <eval>:1:16(3)

> kaia.getStakingInfo("30")
Error: missing trie node 25b62b34e5d1f2b5ccc2349ff7da9a7f73abe7b154c6153ff3aa7459ba270800 (path )
	at web3.js:6812:9(39)
	at send (web3.js:5223:62(29))
	at <eval>:1:20(3)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyeonLewis hyeonLewis self-assigned this Jul 15, 2024
@hyeonLewis hyeonLewis changed the title Preload staking info Preload staking info only at startup Jul 15, 2024
@hyeonLewis hyeonLewis force-pushed the preload-stakinginfo branch from 25b63fc to c6ae429 Compare July 15, 2024 12:34
@hyeonLewis hyeonLewis force-pushed the preload-stakinginfo branch from c6ae429 to 785268c Compare July 15, 2024 12:49
@hyeonLewis hyeonLewis force-pushed the preload-stakinginfo branch from 785268c to eeec7da Compare July 16, 2024 01:05
consensus/consensus.go Outdated Show resolved Hide resolved
@hyeonLewis hyeonLewis marked this pull request as ready for review July 16, 2024 02:38
@blukat29 blukat29 mentioned this pull request Jul 16, 2024
22 tasks
Copy link
Collaborator

@ian0371 ian0371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can consider these in the next PR.

reward/staking_manager.go Show resolved Hide resolved
reward/staking_manager.go Show resolved Hide resolved
@blukat29 blukat29 merged commit b23ad43 into dev Jul 17, 2024
11 checks passed
@blukat29 blukat29 deleted the preload-stakinginfo branch July 17, 2024 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants