-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload staking info only at startup #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonLewis
force-pushed
the
preload-stakinginfo
branch
from
July 15, 2024 12:34
25b63fc
to
c6ae429
Compare
hyeonLewis
force-pushed
the
preload-stakinginfo
branch
from
July 15, 2024 12:49
c6ae429
to
785268c
Compare
hyeonLewis
force-pushed
the
preload-stakinginfo
branch
from
July 16, 2024 01:05
785268c
to
eeec7da
Compare
blukat29
reviewed
Jul 16, 2024
blukat29
reviewed
Jul 16, 2024
hyeonLewis
requested review from
ian0371,
hyunsooda,
2dvorak,
kjeom,
JayChoi1736,
aidan-kwon and
jeongkyun-oh
as code owners
July 16, 2024 02:38
blukat29
reviewed
Jul 16, 2024
blukat29
reviewed
Jul 16, 2024
blukat29
approved these changes
Jul 16, 2024
blukat29
approved these changes
Jul 16, 2024
ian0371
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can consider these in the next PR.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is similar with #46 except that it only regenerates and preloads staking info at node start up. The existing APIs will bubble up if user requests info at stateless block (or blocks).
How it differs from #46:
APIs example
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...