Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reward: SupplyManager correctly handles block rewinds #67

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Aug 13, 2024

Proposed changes

  1. SupplyManager catchup thread is guarded against out-of-order ChainHeadEvent that might be emitted after block rewind (i.e. debug_setHead)
  2. Block rewind (i.e. BlockChain.setHeadBeyondRoot) involves deletion of SupplyCheckpoints, and restarting the catchup thread.
  3. Invalidate existing supply checkpoints (dubbed "accRewards"), triggers every node upgrading to v1.0.2 re-accumulate from the genesis. Because of the bug, nodes v1.0.1 or earlier which undergone setHead at least once might have corrupt accRewards data.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29 blukat29 force-pushed the supply-api-rewind branch 2 times, most recently from 1fda425 to 0faa8f7 Compare August 13, 2024 05:16
@blukat29 blukat29 marked this pull request as ready for review August 13, 2024 06:20
@blukat29 blukat29 mentioned this pull request Aug 13, 2024
4 tasks
@blukat29
Copy link
Contributor Author

Fixed api_backend_test unit test and linter.

Makes items created by v1.0.1 or prior obsolete. Nodes upgraded to
v1.0.2 are re-accumulated from the genesis.
@blukat29 blukat29 merged commit 1486c46 into kaiachain:dev Aug 13, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@blukat29 blukat29 deleted the supply-api-rewind branch August 21, 2024 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants