-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reward: SupplyManager correctly handles block rewinds #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
force-pushed
the
supply-api-rewind
branch
2 times, most recently
from
August 13, 2024 05:16
1fda425
to
0faa8f7
Compare
blukat29
force-pushed
the
supply-api-rewind
branch
from
August 13, 2024 06:18
7d6c935
to
91c257e
Compare
blukat29
requested review from
ian0371,
hyeonLewis,
yoomee1313,
sjnam,
hyunsooda,
2dvorak,
kjeom and
JayChoi1736
as code owners
August 13, 2024 06:20
blukat29
force-pushed
the
supply-api-rewind
branch
from
August 13, 2024 06:39
91c257e
to
f606917
Compare
2dvorak
approved these changes
Aug 13, 2024
ian0371
approved these changes
Aug 13, 2024
blukat29
force-pushed
the
supply-api-rewind
branch
from
August 13, 2024 07:05
f606917
to
80305b4
Compare
blukat29
force-pushed
the
supply-api-rewind
branch
from
August 13, 2024 07:15
80305b4
to
2ce37f0
Compare
Fixed api_backend_test unit test and linter. |
hyunsooda
reviewed
Aug 13, 2024
Makes items created by v1.0.1 or prior obsolete. Nodes upgraded to v1.0.2 are re-accumulated from the genesis.
hyunsooda
approved these changes
Aug 13, 2024
jeongkyun-oh
approved these changes
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
debug_setHead
. See https://app.circleci.com/pipelines/github/kaiachain/kaia/355/workflows/a330fe31-08f5-4771-bd3a-3459d4849a70/jobs/1776 andreward/supply_manager_test.go:TestCatchupRewind
for the test reproducing it.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...