Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: Tidy up default bootnodes #80

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

2dvorak
Copy link
Contributor

@2dvorak 2dvorak commented Sep 5, 2024

Proposed changes

  • This PR updates bootnode URLs to kaia.io domain.
  • Also removed CN and PN bootnodes, because CN bootnodes are set by node config and PN peers are set by static-nodes.json (we don't operate PN bootnode).

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@2dvorak 2dvorak self-assigned this Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@2dvorak 2dvorak requested a review from markyim-kaia September 5, 2024 05:49
@2dvorak
Copy link
Contributor Author

2dvorak commented Sep 5, 2024

I have read the CLA Document and I hereby sign the CLA

@2dvorak 2dvorak marked this pull request as ready for review September 5, 2024 05:55
@2dvorak 2dvorak changed the title Update bootnode URLs to kaia domain Tidy up bootnodes Sep 6, 2024
@blukat29 blukat29 merged commit 8666c1b into dev Sep 6, 2024
11 checks passed
@blukat29 blukat29 changed the title Tidy up bootnodes params: Tidy up default bootnodes Sep 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@blukat29 blukat29 deleted the 2dvorak/update-bn-url-kaia branch September 10, 2024 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants