Drop luet, image extractor, drop build code and multiarch images #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
pull
branch
15 times, most recently
from
52e275e to
a774a4e
Compare
- drop luet - use image extractor for pulling images instead of luet - drop channel sources - introduce archfor images - drop build commands and useless code no needed - add pull-image command Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
|
This needs a docs update as we no longer support the auth flags for upgrade. We now support any type of docker auth that docker provides and it extends to anything using the pull, i.e. install,upgrade,pull-image So it will look into: ~/.docker/config.json, or %USERPROFILE%.docker\config.json by default In that given order. So we need to document this after this is merged |
|
docs PR here kairos-io/kairos-docs#9 |
Co-authored-by: Mauro Morales <[email protected]>
jimmykarily
reviewed
May 17, 2023
| @@ -343,12 +343,11 @@ var _ = Describe("Install action tests", func() { | |||
|
|
|||
| It("Fails if luet fails to unpack image", Label("image", "luet", "unpack"), func() { | |||
There was a problem hiding this comment.
the description should no longer mention "luet" I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itxaka [email protected]