Fix artifact names #103
Merged
Fix artifact names #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
20 tasks
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
mauromorales
reviewed
Nov 2, 2023
mauromorales
reviewed
Nov 2, 2023
hugo.toml
Outdated
Comment on lines
129
to
130
| exampleImageCoreTag = "leap-15.5-core-amd64-generic-v2.4.1" | ||
| exampleImageStandardTag = "leap-15.5-core-amd64-generic-v2.4.1-k3sv1.27.3-k3s1" |
There was a problem hiding this comment.
Suggested change
| exampleImageCoreTag = "leap-15.5-core-amd64-generic-v2.4.1" | |
| exampleImageStandardTag = "leap-15.5-core-amd64-generic-v2.4.1-k3sv1.27.3-k3s1" | |
| exampleImageCoreTag = "leap-15.5-core-amd64-generic-v2.4.1" | |
| exampleImageStandardTag = "leap-15.5-standard-amd64-generic-v2.4.1-k3sv1.27.3-k3s1" |
Standard one is incorrect here, but overall, I would prefer not to do this here since it will keep the versions of the examples pinned. I think it would be better to build them using the mechanism we already have with the version.
"{{< registryURL >}}/{{< exampleImage >}}:leap-15.5-core-amd64-generic-{{< kairosVersion >}}"
Or even better, maybe introduce another function which itself does the code above and can be used like so:
"{{< registryURL >}}/{{< exampleStandardImage >}}
maybe even go as far as
{{< exampleStandardImage >}}
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: kairos-io/kairos#1978
Fixes kairos-io/kairos#103